Qpid
  1. Qpid
  2. QPID-2824

Use toLogString rather than toString on LogSubject(s)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: Java Broker
    • Labels:
      None

      Description

      Currently the LogSubject and the subsequent implementation classes are using toString method to provide the log subject - I think it is better to use toLogString so the LogSubject interface can be implemented by other object without impacting the generic toString method which could be use for some other purposes.

      1. qpid-2824.patch
        13 kB
        Sorin Suciu

        Activity

        Sorin Suciu created issue -
        Sorin Suciu made changes -
        Field Original Value New Value
        Attachment qpid-2824.patch [ 12453228 ]
        Hide
        Sorin Suciu added a comment -

        This is for the test suite - AbstractTestMessages is modified to use toLogString rather than toString.

        Show
        Sorin Suciu added a comment - This is for the test suite - AbstractTestMessages is modified to use toLogString rather than toString.
        Sorin Suciu made changes -
        Attachment qpid-2824_1.patch [ 12453410 ]
        Hide
        Sorin Suciu added a comment -

        Patch combining the previous 2 patches and fixing tests.

        Show
        Sorin Suciu added a comment - Patch combining the previous 2 patches and fixing tests.
        Sorin Suciu made changes -
        Attachment qpid-2824.patch [ 12453416 ]
        Sorin Suciu made changes -
        Attachment qpid-2824.patch [ 12453228 ]
        Sorin Suciu made changes -
        Attachment qpid-2824_1.patch [ 12453410 ]
        Sorin Suciu made changes -
        Attachment qpid-2824.patch [ 12453416 ]
        Sorin Suciu made changes -
        Attachment qpid-2824.patch [ 12453423 ]
        Robbie Gemmell made changes -
        Summary Use toLogString rather than toString on LogSubject(s) and add a new GenericActor for logging 0-10 op log messages Use toLogString rather than toString on LogSubject(s)
        Assignee Robbie Gemmell [ gemmellr ]
        Description Currently the LogSubject and the subsequent implementation classes are using toString method to provide the log subject - I think it is better to use toLogString so the LogSubject interface can be implemented by other object without impacting the generic toString method which could be use for some other purposes. Also having a GenericActor could be useful for non-specialized cases where the LogSubject does not need complex constructs. Currently the LogSubject and the subsequent implementation classes are using toString method to provide the log subject - I think it is better to use toLogString so the LogSubject interface can be implemented by other object without impacting the generic toString method which could be use for some other purposes.
        Hide
        Robbie Gemmell added a comment -

        Patch applied.

        Show
        Robbie Gemmell added a comment - Patch applied.
        Robbie Gemmell made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Sorin Suciu made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development