Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-2824

Use toLogString rather than toString on LogSubject(s)

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: Broker-J
    • Labels:
      None

      Description

      Currently the LogSubject and the subsequent implementation classes are using toString method to provide the log subject - I think it is better to use toLogString so the LogSubject interface can be implemented by other object without impacting the generic toString method which could be use for some other purposes.

      1. qpid-2824.patch
        13 kB
        Sorin Suciu

        Activity

        Hide
        sorins Sorin Suciu added a comment -

        This is for the test suite - AbstractTestMessages is modified to use toLogString rather than toString.

        Show
        sorins Sorin Suciu added a comment - This is for the test suite - AbstractTestMessages is modified to use toLogString rather than toString.
        Hide
        sorins Sorin Suciu added a comment -

        Patch combining the previous 2 patches and fixing tests.

        Show
        sorins Sorin Suciu added a comment - Patch combining the previous 2 patches and fixing tests.
        Hide
        gemmellr Robbie Gemmell added a comment -

        Patch applied.

        Show
        gemmellr Robbie Gemmell added a comment - Patch applied.

          People

          • Assignee:
            gemmellr Robbie Gemmell
            Reporter:
            sorins Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development