Qpid
  1. Qpid
  2. QPID-2783

Eliminate the UnknownMessageTypeException from o.a.q.server.protocol package

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: Java Broker
    • Labels:
      None

      Description

      The UnknownMessageTypeException is only used in AMQProtocolEngine and uses AMQException in a deprecated fashion. As the framing layer is catching any throwable, we can replace it with a AMQException in the AMQProtocolEngine and remove that class as it is a bit misplaced in the protocol package.

        Activity

        Sorin Suciu created issue -
        Sorin Suciu made changes -
        Field Original Value New Value
        Attachment qpid-2783.patch [ 12451039 ]
        Sorin Suciu made changes -
        Attachment qpid-2783.patch [ 12451417 ]
        Sorin Suciu made changes -
        Attachment qpid-2783.patch [ 12451039 ]
        Sorin Suciu made changes -
        Description The UnknownMessageTypeException is only used in AMQProtocolEngine and uses AMQException in a deprecated fashion. As the framing layer is catching any throwable, we can replace it with a ClassCastException in the AMQProtocolEngine and remove that class as it is a bit misplaced in the protocol package. The UnknownMessageTypeException is only used in AMQProtocolEngine and uses AMQException in a deprecated fashion. As the framing layer is catching any throwable, we can replace it with a AMQException in the AMQProtocolEngine and remove that class as it is a bit misplaced in the protocol package.
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Robbie Gemmell added a comment -

        Patch applied.

        Show
        Robbie Gemmell added a comment - Patch applied.
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Sorin Suciu made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        6d 2h 58m 1 Robbie Gemmell 08/Aug/10 16:56
        In Progress In Progress Resolved Resolved
        1m 1 Robbie Gemmell 08/Aug/10 16:57
        Resolved Resolved Closed Closed
        50d 17h 41m 1 Sorin Suciu 28/Sep/10 10:39

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development