Qpid
  1. Qpid
  2. QPID-2775

use JMX to reload the security configuration for FirewallConfigTest

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: Java Tests
    • Labels:
      None

      Description

      Sometimes this test fails when ran on slow machines. Therefore it would help to increase the timeout.

        Activity

        Sorin Suciu created issue -
        Sorin Suciu made changes -
        Field Original Value New Value
        Attachment qpid-2775.patch [ 12450823 ]
        Hide
        Robbie Gemmell added a comment -

        I just saw this fail on one of my machines, whcih isnt all that slow. The issue is that the configuration is reloaded asynchronously by starting another process to SIGHUP the broker and then immediately waiting for the log entry to appear. The configuration reload now takes longer than it used to, occasionally exceeding the timeout. Simply increasing the timeout just leaves us open to the same happening in future or even now on much slower machines. Additionally, the attached patch manipulates the static timeout variable during the test runs and so ends up altering the value for all subsequent tests as well.

        There has long been a //FIXME in the associated QBTC method which performs the reload indicating that it should instead use the JMX interface to undertake the task. I have just updated it to do so, which should resolve the issue as the reload is now synchronous and the timeout should now be purely for the log file processing, as with other logging tests.

        Show
        Robbie Gemmell added a comment - I just saw this fail on one of my machines, whcih isnt all that slow. The issue is that the configuration is reloaded asynchronously by starting another process to SIGHUP the broker and then immediately waiting for the log entry to appear. The configuration reload now takes longer than it used to, occasionally exceeding the timeout. Simply increasing the timeout just leaves us open to the same happening in future or even now on much slower machines. Additionally, the attached patch manipulates the static timeout variable during the test runs and so ends up altering the value for all subsequent tests as well. There has long been a //FIXME in the associated QBTC method which performs the reload indicating that it should instead use the JMX interface to undertake the task. I have just updated it to do so, which should resolve the issue as the reload is now synchronous and the timeout should now be purely for the log file processing, as with other logging tests.
        Robbie Gemmell made changes -
        Summary Increase the timeout interval for FirewallConfigTest use JMX to reload the security configuration for FirewallConfigTest
        Assignee Robbie Gemmell [ gemmellr ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Sorin Suciu made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Sorin Suciu made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development