[QPID-2770] AMQMessageDelegate_0_10 uses Byte.valueOf() when converting String properties to short, int, and long values

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: M4, 0.5, 0.6, 0.14
• Fix Version/s: 0.15
• Component/s: JMS AMQP 0-x
• Assignee: Robbie Gemmell
• Reporter: Robbie Gemmell
• Created: 28/Jul/10 11:15
• Updated: 14/Mar/17 20:07
• Resolved: 20/Feb/12 14:21

Description

AMQMessageDelegate_0_10 uses Byte.valueOf() when converting String properties to short, int, and long values. When setStringProperty() is used to to set a value and this is to be retrieved via getShortProperty(), getIntProperty(), getLongProperty() methods then the conversion is delegated to the next lowest property type and eventually to the getByteProperty() method and is thus likely not to function correctly.

Each of the short, int, and long property retrieval methods should directly convert the String instead of delegating to the lower property method.

Eg, getLongProperty which delegates the String to getIntProperty, which delegates it to getShortProperty() and eventually getByteProperty():

if(o instanceof Long)

{ return ((Long)o).longValue(); }

else
{
try

{ return Long.valueOf(getIntProperty(propertyName)); }

Issue Links

• is related to: QPID-2776 refactor AMQMessageDelegate(0_8 / 0_10) to rationalise duplicated message property functionality