Qpid
  1. Qpid
  2. QPID-2695

VirtualHostConfigRecoveryHandler can NPE or bind to the wrong exchange on binding recovery

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6, 0.7
    • Fix Version/s: 0.7
    • Component/s: Java Broker
    • Labels:
      None

      Description

      VirtualHostConfigRecoveryHandler.binding() can NPE if an exchange isnt found when recovering a binding to a queue which also doesnt exist. Additionally, if the NPE (which will occur in an error log statement) does not occur because the queue does exist, then the binding can be created to the default exchange in error.

        Activity

        Hide
        Robbie Gemmell added a comment -

        Behaviour updated to prevent NPE while logging, and abort binding recoery if the exchange doesnt exist rather than continue and have the binding factory use the default exchange instead.

        Show
        Robbie Gemmell added a comment - Behaviour updated to prevent NPE while logging, and abort binding recoery if the exchange doesnt exist rather than continue and have the binding factory use the default exchange instead.
        Hide
        Marnie McCormack added a comment -

        Changes look fine

        Show
        Marnie McCormack added a comment - Changes look fine

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development