Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: Java Broker
    • Labels:
      None

      Description

      Having an OSGI plugin that would shutdown the broker via a JMX command (other possibilities would be listening to a port or to a certain queue) could be useful at least for testing purposes.

      1. qpid-2678.patch
        9 kB
        Sorin Suciu
      2. 0001-QPID-2768-OSGI-Shutdown-module.patch
        13 kB
        Andrew Kennedy

        Activity

        Hide
        Sorin Suciu added a comment -

        An Initial version, tests coming...

        Show
        Sorin Suciu added a comment - An Initial version, tests coming...
        Hide
        Robbie Gemmell added a comment -

        The use of system.out.println() should be removed.

        Why make a new ScheduledThreadPoolExecutor at every call of the shutdown(delay) method? I would change it to an instance variable I think. Also, given that it is simply going to shut down the JVM when it runs the first scheduled task it probably only needs 1 thread instead of 3.

        It doesnt seem like the build.xml file should be overriding the bundle task? There is no .bnd file to be processed for the module and there is a specific manifest provided anyway.

        Show
        Robbie Gemmell added a comment - The use of system.out.println() should be removed. Why make a new ScheduledThreadPoolExecutor at every call of the shutdown(delay) method? I would change it to an instance variable I think. Also, given that it is simply going to shut down the JVM when it runs the first scheduled task it probably only needs 1 thread instead of 3. It doesnt seem like the build.xml file should be overriding the bundle task? There is no .bnd file to be processed for the module and there is a specific manifest provided anyway.
        Hide
        Sorin Suciu added a comment -

        Thanks for the comments Robbie, I will look to address them.

        Show
        Sorin Suciu added a comment - Thanks for the comments Robbie, I will look to address them.
        Hide
        Sorin Suciu added a comment -

        Issues pointed by Robbie were addressed.

        Show
        Sorin Suciu added a comment - Issues pointed by Robbie were addressed.
        Hide
        Robbie Gemmell added a comment -

        The Activator class is no longer properly formatted, and still contains System.out logging.

        The Manifest should probably lose these newly added lines:
        +Ant-Version: Apache Ant 1.7.1
        +Created-By: 16.3-b01-279 (Apple Inc.)

        Show
        Robbie Gemmell added a comment - The Activator class is no longer properly formatted, and still contains System.out logging. The Manifest should probably lose these newly added lines: +Ant-Version: Apache Ant 1.7.1 +Created-By: 16.3-b01-279 (Apple Inc.)
        Hide
        Andrew Kennedy added a comment -

        Updated patch

        Show
        Andrew Kennedy added a comment - Updated patch
        Hide
        Andrew Kennedy added a comment -

        Needs tests added

        Show
        Andrew Kennedy added a comment - Needs tests added
        Hide
        Andrew Kennedy added a comment -

        Committed updated code from review with Sorin S <ssuciu@gmail.com>

        Show
        Andrew Kennedy added a comment - Committed updated code from review with Sorin S <ssuciu@gmail.com>
        Hide
        Andrew Kennedy added a comment - - edited

        See http://svn.apache.org/viewvc?view=revision&revision=1026929 for associated subversion commits.

        I have now edited the commit message, but it won't show up here. Apologies.

        Show
        Andrew Kennedy added a comment - - edited See http://svn.apache.org/viewvc?view=revision&revision=1026929 for associated subversion commits. I have now edited the commit message, but it won't show up here. Apologies.
        Hide
        Andrew Kennedy added a comment -

        Reviewed and committed patch from Sorin S <ssuciu@gmail.com>

        Show
        Andrew Kennedy added a comment - Reviewed and committed patch from Sorin S <ssuciu@gmail.com>

          People

          • Assignee:
            Sorin Suciu
            Reporter:
            Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development