Qpid
  1. Qpid
  2. QPID-2672

unroutable persistent messages should be immediately removed from or never flushed to the message store

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.13
    • Component/s: Java Broker
    • Labels:
      None

      Description

      At present, persistent messages are put into the message store regardless whether they can/will be enqueued on a queue. When it is determined they cannot be routed, they are not removed from the store. As a result, it is left until startup recovery sequence until they are determined to be orphans and are ejected from the store. This process can dramatically slow startup time and should be undertaken as soon as it is known the message is to be discard (or even just stop them being commited/flushed to the store at all - they should be known to the store though to ensure a message id is assigned).

        Activity

        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Robbie Gemmell added a comment -

        Changes seem reasonable to me.

        Show
        Robbie Gemmell added a comment - Changes seem reasonable to me.
        Keith Wall made changes -
        Assignee Keith Wall [ k-wall ] Robbie Gemmell [ gemmellr ]
        Hide
        Keith Wall added a comment -

        Hi Robbie, Could you review this change? Thanks Keith.

        Show
        Keith Wall added a comment - Hi Robbie, Could you review this change? Thanks Keith.
        Hide
        Keith Wall added a comment -

        ServerSessionDelegate has been refactored so unroutable messages are no longer written to the store. In addition, an operational logging message has been introduced (EXH-1003) that is used when the an unroutable message is received by the Broker. Operational logging message is backported to the 0-8..0-9-1 code path too.

        Show
        Keith Wall added a comment - ServerSessionDelegate has been refactored so unroutable messages are no longer written to the store. In addition, an operational logging message has been introduced (EXH-1003) that is used when the an unroutable message is received by the Broker. Operational logging message is backported to the 0-8..0-9-1 code path too.
        Keith Wall made changes -
        Fix Version/s 0.13 [ 12316854 ]
        Keith Wall made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Keith Wall made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Keith Wall made changes -
        Assignee Keith Wall [ k-wall ]
        Robbie Gemmell made changes -
        Field Original Value New Value
        Fix Version/s 0.7 [ 12314455 ]
        Hide
        Robbie Gemmell added a comment -

        Updating 'Fix For' to Unknown on issues not targeted for 0.8

        Show
        Robbie Gemmell added a comment - Updating 'Fix For' to Unknown on issues not targeted for 0.8
        Robbie Gemmell created issue -

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development