[QPID-2668] PlainPasswordPrincipalDatabase - code improvement

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.6, 0.7
• Fix Version/s: 0.7
• Component/s: Broker-J
• Assignee: Robbie Gemmell
• Reporter: Sorin Suciu
• Created: 14/Jun/10 11:33
• Updated: 28/Sep/10 09:41
• Resolved: 01/Aug/10 16:18

Description

This snippet:
try
{
try
{
_userUpdate.lock();
char[] orig = user.getPassword();
user.setPassword(password);

try

{ savePasswordFile(); }

catch (IOException e)

{ _logger.error("Unable to save password file, password change for user '" + principal + "' discarded"); //revert the password change user.setPassword(orig); return false; }

return true;
}
finally
{
if (_userUpdate.isHeldByCurrentThread())

{ _userUpdate.unlock(); }

}
}
catch (Exception e)

{ return false; }

is flagged by our Sonar server. This patch will streamline the code.