[QPID-2653] Double checked locking in org.apache.qpid.server.transport.ThreadPoolFilter

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 0.7
• Fix Version/s: 0.7
• Component/s: Broker-J
• Assignee: Sorin Suciu
• Reporter: Sorin Suciu
• Created: 09/Jun/10 12:13
• Updated: 04/Oct/10 14:33
• Resolved: 01/Aug/10 16:08

Description

org.apache.qpid.server.transport.ThreadPoolFilter has a double check locking in this method:

private SessionBuffer getSessionBuffer(IoSession session)
{
final Map buffers = this.buffers;
SessionBuffer buf = (SessionBuffer) buffers.get(session);
if (buf == null)
{
synchronized (buffers)
{
buf = (SessionBuffer) buffers.get(session);
if (buf == null)

{ buf = new SessionBuffer(session); buffers.put(session, buf); }

}
}
return buf;
}

Issue Links

• duplicates: QPID-2757 Remove double-checked-locking in ThreadPoolFilter