Qpid
  1. Qpid
  2. QPID-2639

Add functionality to exclude any test using the current exclude mechanism

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Later
    • Affects Version/s: None
    • Fix Version/s: JIRA Cleanup
    • Component/s: Java Tests
    • Labels:
      None

      Description

      Currently only tests extending QpidTestCase can be excluded using the exclude file mechanism employed by the java ant tests.
      There are several test cases that does not need to be run with every profile, but they cannot be excluded since they don't extend QpidTestCase.

      Ex. SlowConsumerDetectionConfigurationTest is exclusively for the java broker and does not need to be run when using the cpp test profiles.

      On the other hand you cannot make them extend QpidTestCase as by default this class will start a broker.
      Therefore it would be nice if we have a simple class that implements the exclusion and then the current QpidTestCase to extend it.

      I think it's best if we have a simple class called QpidTestCase that implements the exclude functionality (and perhaps capture the test output as well) and then rename the current QpidTestCase to QpidBrokerTestCase and make it extend QpidTestCase.

      This will allow us to easily extend any JUnit test case from the profiles.

        Activity

        Hide
        Robbie Gemmell added a comment -

        Closing issue out as part of JIRA cleanup. Issue may already be resolved, may be invalid, or may never be fixed. See QPID-3469 for further details.

        Show
        Robbie Gemmell added a comment - Closing issue out as part of JIRA cleanup. Issue may already be resolved, may be invalid, or may never be fixed. See QPID-3469 for further details.
        Hide
        Rajith Attapattu added a comment -

        How about if we move QpidTestCase to the common module? (The QpidBrokerTestCase should be in systests).
        That would allow any module to leverage the QpidTestCase.
        Right now if the broker module is going to use QpidTestCase then it will have a dependency on the systests which already has a dep on the broker module and circular deps are never a good thing.

        Show
        Rajith Attapattu added a comment - How about if we move QpidTestCase to the common module? (The QpidBrokerTestCase should be in systests). That would allow any module to leverage the QpidTestCase. Right now if the broker module is going to use QpidTestCase then it will have a dependency on the systests which already has a dep on the broker module and circular deps are never a good thing.

          People

          • Assignee:
            Unassigned
            Reporter:
            Rajith Attapattu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development