Qpid
  1. Qpid
  2. QPID-2619

Capture the PID for the qpid broker on unix platforms

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: Java Broker
    • Labels:
      None

      Description

      As of now we are not capturing the pid for the qpid process upon start. This can be useful for monitoring purposes.

        Activity

        Hide
        Sorin Suciu added a comment -

        Looks good.

        Show
        Sorin Suciu added a comment - Looks good.
        Hide
        Robbie Gemmell added a comment -

        I have made the suggested changes I suggested above, also making the pid filename configurable to e.g. allow use with multiple brokers.

        Show
        Robbie Gemmell added a comment - I have made the suggested changes I suggested above, also making the pid filename configurable to e.g. allow use with multiple brokers.
        Hide
        Robbie Gemmell added a comment -

        I would say the pid file export is in the wrong place, it should be in the qpid-server script and not qpid-run; other scripts also use qpid-run and so would overwrite the broker pid file if used afterwards. Moving it would also mean duplicating the defaulting of QPID_WORK definition in qpid-run (which I notice is still using readlink) but I think that is ok given the alternative.

        I would probably also rename the pid file to qpid-server.pid to be clearer.

        Show
        Robbie Gemmell added a comment - I would say the pid file export is in the wrong place, it should be in the qpid-server script and not qpid-run; other scripts also use qpid-run and so would overwrite the broker pid file if used afterwards. Moving it would also mean duplicating the defaulting of QPID_WORK definition in qpid-run (which I notice is still using readlink) but I think that is ok given the alternative. I would probably also rename the pid file to qpid-server.pid to be clearer.
        Hide
        Andrew Kennedy added a comment -

        Applied patch and committed

        Show
        Andrew Kennedy added a comment - Applied patch and committed

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development