Qpid
  1. Qpid
  2. QPID-2608

AMQPException messages contain duplicate AMQConstant text

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.5, 0.6
    • Fix Version/s: 0.7
    • Component/s: Java Broker, Java Client
    • Labels:
      None

      Description

      The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.

        Activity

        Andrew Kennedy created issue -
        Hide
        Andrew Kennedy added a comment -

        Move message extraction from AMQPConstant to toString and added an AMQPSecurityException subclass

        Show
        Andrew Kennedy added a comment - Move message extraction from AMQPConstant to toString and added an AMQPSecurityException subclass
        Andrew Kennedy made changes -
        Field Original Value New Value
        Attachment 0004-QPID-2608-AMQPException-messages-contain-duplicate.patch [ 12444679 ]
        Andrew Kennedy made changes -
        Attachment 0004-QPID-2608-AMQPException-messages-contain-duplicate.patch [ 12444679 ]
        Hide
        Andrew Kennedy added a comment -

        Removed reference to AMQSecurityException

        Show
        Andrew Kennedy added a comment - Removed reference to AMQSecurityException
        Andrew Kennedy made changes -
        Attachment 0003-QPID-2608-AMQPException-messages-contain-duplicate.patch [ 12445318 ]
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ]
        Hide
        Robbie Gemmell added a comment -

        The override on toString() to clean up the error code cloning in cloneForCurrentThread() doesnt print the class name as the standard Throwable output would, it would be good to put this back in.

        Show
        Robbie Gemmell added a comment - The override on toString() to clean up the error code cloning in cloneForCurrentThread() doesnt print the class name as the standard Throwable output would, it would be good to put this back in.
        Andrew Kennedy made changes -
        Attachment 0003-QPID-2608-AMQPException-messages-contain-duplicate.patch [ 12445318 ]
        Hide
        Andrew Kennedy added a comment -

        Updated patch based on review comments

        Show
        Andrew Kennedy added a comment - Updated patch based on review comments
        Andrew Kennedy made changes -
        Hide
        Andrew Kennedy added a comment -

        Updated ExternalACLJMXTest to reflect changes in the AMQException toString method when examining exception stacktraces

        Show
        Andrew Kennedy added a comment - Updated ExternalACLJMXTest to reflect changes in the AMQException toString method when examining exception stacktraces
        Andrew Kennedy made changes -
        Attachment 0001-QPID-2608-Update-test-to-reflect-changes-to-excepti.patch [ 12445325 ]
        Andrew Kennedy made changes -
        Attachment 0001-QPID-2608-Update-test-to-reflect-changes-to-excepti.patch [ 12445325 ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Robbie Gemmell added a comment -

        Appled patch: 0001-QPID-2608-AMQPException-messages-contain-duplicate.patch

        Show
        Robbie Gemmell added a comment - Appled patch: 0001- QPID-2608 -AMQPException-messages-contain-duplicate.patch
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Andrew Kennedy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development