Qpid
  1. Qpid
  2. QPID-2530

Refactor the broker-plugins directory setup to allow adding new modules

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7
    • Component/s: None
    • Labels:
      None

      Description

      The broker-plugins is currently having only one module (DiagnosticExchange and TestExchange). We should have a directory for each module building as a separate jar. This would allow adding a new module to be just a matter of creating a new directory and adding it to the build system, We should move the content of the src directory to its own plugin directory and adjust the build system accordingly. Suggested layout:

      broker-plugins
      ---> build.xml
      ---> extras (OSGI-Plugin)
      ---> my_plugin1 (OSGI-Plugin)
      ---> my_plugin2 (OSGI-Plugin)
      .... etc

      Please perform the following: on java/broker-plugins folder:

      • delete the src folder and untar the tarball attached
      • remove the build.xml and add the attached build.xml
      • apply QPID-2502 to fix the PluginManager.java issue with security tracker
      • apply QPID-2513
      • apply QPID-2531 to update the build.deps and main build.xml
      1. build.xml
        1 kB
        Sorin Suciu
      2. extras.tgz
        4 kB
        Sorin Suciu

        Activity

        Sorin Suciu created issue -
        Martin Ritchie made changes -
        Field Original Value New Value
        Assignee Martin Ritchie [ ritchiem ]
        Sorin Suciu made changes -
        Attachment build.xml [ 12442558 ]
        Sorin Suciu made changes -
        Attachment extras.tgz [ 12442559 ]
        Sorin Suciu made changes -
        Description The broker-plugins is currently having only one module (DiagnosticExchange and TestExchange). We should have a directory for each module building as a separate jar. This would allow adding a new module to be just a matter of creating a new directory and adding it to the build system, We should move the content of the src directory to its own plugin directory and adjust the build system accordingly. Suggested layout:


        broker-plugins
            ---> build.xml
            ---> extras (OSGI-Plugin)
            ---> my_plugin1 (OSGI-Plugin)
            ---> my_plugin2 (OSGI-Plugin)
            .... etc
        The broker-plugins is currently having only one module (DiagnosticExchange and TestExchange). We should have a directory for each module building as a separate jar. This would allow adding a new module to be just a matter of creating a new directory and adding it to the build system, We should move the content of the src directory to its own plugin directory and adjust the build system accordingly. Suggested layout:


        broker-plugins
            ---> build.xml
            ---> extras (OSGI-Plugin)
            ---> my_plugin1 (OSGI-Plugin)
            ---> my_plugin2 (OSGI-Plugin)
            .... etc

        Please perform the following: on java/broker-plugins folder:
        - delete the src folder and untar the tarball attached
        - remove the build.xml and add the attached build.xml
        - apply QPID-2531 to update the build.deps and main build.xml
        - apply QPID-2513


        Sorin Suciu made changes -
        Description The broker-plugins is currently having only one module (DiagnosticExchange and TestExchange). We should have a directory for each module building as a separate jar. This would allow adding a new module to be just a matter of creating a new directory and adding it to the build system, We should move the content of the src directory to its own plugin directory and adjust the build system accordingly. Suggested layout:


        broker-plugins
            ---> build.xml
            ---> extras (OSGI-Plugin)
            ---> my_plugin1 (OSGI-Plugin)
            ---> my_plugin2 (OSGI-Plugin)
            .... etc

        Please perform the following: on java/broker-plugins folder:
        - delete the src folder and untar the tarball attached
        - remove the build.xml and add the attached build.xml
        - apply QPID-2531 to update the build.deps and main build.xml
        - apply QPID-2513


        The broker-plugins is currently having only one module (DiagnosticExchange and TestExchange). We should have a directory for each module building as a separate jar. This would allow adding a new module to be just a matter of creating a new directory and adding it to the build system, We should move the content of the src directory to its own plugin directory and adjust the build system accordingly. Suggested layout:


        broker-plugins
            ---> build.xml
            ---> extras (OSGI-Plugin)
            ---> my_plugin1 (OSGI-Plugin)
            ---> my_plugin2 (OSGI-Plugin)
            .... etc

        Please perform the following: on java/broker-plugins folder:
        - delete the src folder and untar the tarball attached
        - remove the build.xml and add the attached build.xml
        - apply QPID-2502 to fix the PluginManager.java issue with security tracker
        - apply QPID-2513
        - apply QPID-2531 to update the build.deps and main build.xml




        Martin Ritchie made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Martin Ritchie made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Martin Ritchie made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Robbie Gemmell added a comment -

        Reopening to resolve the feedback issues discussed on the QPID-2531 JIRA.

        Show
        Robbie Gemmell added a comment - Reopening to resolve the feedback issues discussed on the QPID-2531 JIRA.
        Robbie Gemmell made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Martin Ritchie [ ritchiem ] Robbie Gemmell [ gemmellr ]
        Hide
        Martin Ritchie added a comment -

        Hi Robbie, can you take a look at these changes.

        Show
        Martin Ritchie added a comment - Hi Robbie, can you take a look at these changes.
        Hide
        Robbie Gemmell added a comment -

        Changes look good.

        Show
        Robbie Gemmell added a comment - Changes look good.
        Robbie Gemmell made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Assignee Robbie Gemmell [ gemmellr ] Martin Ritchie [ ritchiem ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        1d 8h 31m 1 Martin Ritchie 23/Apr/10 16:38
        In Progress In Progress Reviewable Reviewable
        7m 39s 1 Martin Ritchie 23/Apr/10 16:46
        Reviewable Reviewable Resolved Resolved
        9m 49s 1 Martin Ritchie 23/Apr/10 16:56
        Resolved Resolved Reopened Reopened
        1d 27m 1 Robbie Gemmell 24/Apr/10 17:23
        Reopened Reopened Closed Closed
        3d 1h 1m 1 Robbie Gemmell 27/Apr/10 18:25

          People

          • Assignee:
            Martin Ritchie
            Reporter:
            Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development