Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.13
    • Component/s: Java Broker, Java Client
    • Labels:
      None

      Description

      Upgrading Mina to 1.1.7 would allow the removal of backport-util-concurrent.jar from the dependencies.

      1. mina-update.patch
        85 kB
        Emmanuel Bourg
      2. mina-upgrade.patch
        87 kB
        Emmanuel Bourg
      3. 0001-QPID-2498-Upgrade-Mina-to-1.1.7.patch
        1.09 MB
        Keith Wall

        Activity

        Emmanuel Bourg created issue -
        Hide
        Emmanuel Bourg added a comment -

        This patch replaces Mina 1.0.1 with Mina 1.1.7. The Queue and BlockingQueue classes from Mina were replaced by their equivalent in java.util.concurrent. VmPipeIdleStatusChecker has been removed since the issue it worked around has been fixed in Mina 1.1.7.

        Mina 1.1.7 can be downloaded here :

        http://repo1.maven.org/maven2/org/apache/mina/mina-core/1.1.7/mina-core-1.1.7.jar
        http://repo1.maven.org/maven2/org/apache/mina/mina-filter-ssl/1.1.7/mina-filter-ssl-1.1.7.jar

        Show
        Emmanuel Bourg added a comment - This patch replaces Mina 1.0.1 with Mina 1.1.7. The Queue and BlockingQueue classes from Mina were replaced by their equivalent in java.util.concurrent. VmPipeIdleStatusChecker has been removed since the issue it worked around has been fixed in Mina 1.1.7. Mina 1.1.7 can be downloaded here : http://repo1.maven.org/maven2/org/apache/mina/mina-core/1.1.7/mina-core-1.1.7.jar http://repo1.maven.org/maven2/org/apache/mina/mina-filter-ssl/1.1.7/mina-filter-ssl-1.1.7.jar
        Emmanuel Bourg made changes -
        Field Original Value New Value
        Attachment mina.patch [ 12441314 ]
        Hide
        Emmanuel Bourg added a comment -

        There are some unused classes in the mina package that could also be removed:

        org.apache.mina.common.FixedSizeByteBufferAllocator
        org.apache.mina.common.support.DefaultIoFuture
        org.apache.mina.filter.codec.OurCumulativeProtocolDecoder
        org.apache.mina.filter.codec.QpidProtocolCodecFilter

        Show
        Emmanuel Bourg added a comment - There are some unused classes in the mina package that could also be removed: org.apache.mina.common.FixedSizeByteBufferAllocator org.apache.mina.common.support.DefaultIoFuture org.apache.mina.filter.codec.OurCumulativeProtocolDecoder org.apache.mina.filter.codec.QpidProtocolCodecFilter
        Hide
        Emmanuel Bourg added a comment -

        Additional patch to account for the latest changes in AddressBasedDestinationTest by rajith (rev 934563)

        Show
        Emmanuel Bourg added a comment - Additional patch to account for the latest changes in AddressBasedDestinationTest by rajith (rev 934563)
        Emmanuel Bourg made changes -
        Attachment mina2.patch [ 12442322 ]
        Hide
        Emmanuel Bourg added a comment -

        Additional patch to update the POMs

        Show
        Emmanuel Bourg added a comment - Additional patch to update the POMs
        Emmanuel Bourg made changes -
        Attachment mina-poms.patch [ 12442331 ]
        Martin Ritchie made changes -
        Assignee Martin Ritchie [ ritchiem ]
        Hide
        Martin Ritchie added a comment -

        Hi Emmanuel,
        Thanks for the patches I'll take a look at these over the next few days.
        Cheers

        Martin

        Show
        Martin Ritchie added a comment - Hi Emmanuel, Thanks for the patches I'll take a look at these over the next few days. Cheers Martin
        Hide
        Emmanuel Bourg added a comment -

        Martin, let me know if you need an updated patch when you are ready to review this change, I'll provide one.

        Show
        Emmanuel Bourg added a comment - Martin, let me know if you need an updated patch when you are ready to review this change, I'll provide one.
        Hide
        Emmanuel Bourg added a comment -

        Updated patch for the latest trunk

        Show
        Emmanuel Bourg added a comment - Updated patch for the latest trunk
        Emmanuel Bourg made changes -
        Attachment mina-update.patch [ 12445672 ]
        Emmanuel Bourg made changes -
        Attachment mina2.patch [ 12442322 ]
        Emmanuel Bourg made changes -
        Attachment mina-poms.patch [ 12442331 ]
        Emmanuel Bourg made changes -
        Attachment mina.patch [ 12441314 ]
        Hide
        Emmanuel Bourg added a comment -

        Is there any chance to get this into the 0.8 release? If someone can review this issue I'll happily update my patch.

        Show
        Emmanuel Bourg added a comment - Is there any chance to get this into the 0.8 release? If someone can review this issue I'll happily update my patch.
        Hide
        Emmanuel Bourg added a comment -

        I updated the patch, it's now available as a branch on Github. Please let me know if this format is not suitable.

        http://github.com/ebourg/qpid/tree/mina-upgrade

        http://github.com/ebourg/qpid/commit/7c4f9e87788261c36ed804f3a13e8ae0c1891205

        Show
        Emmanuel Bourg added a comment - I updated the patch, it's now available as a branch on Github. Please let me know if this format is not suitable. http://github.com/ebourg/qpid/tree/mina-upgrade http://github.com/ebourg/qpid/commit/7c4f9e87788261c36ed804f3a13e8ae0c1891205
        Emmanuel Bourg made changes -
        Attachment mina-upgrade.patch [ 12457536 ]
        Hide
        Andrew Kennedy added a comment -

        Moving to 0.9, due to insufficient testing

        Show
        Andrew Kennedy added a comment - Moving to 0.9, due to insufficient testing
        Andrew Kennedy made changes -
        Assignee Martin Ritchie [ ritchiem ] Andrew Kennedy [ andrew.kennedy ]
        Fix Version/s 0.9 [ 12315382 ]
        Fix Version/s 0.7 [ 12314455 ]
        Robbie Gemmell made changes -
        Fix Version/s 0.11 [ 12316272 ]
        Fix Version/s 0.9 [ 12315382 ]
        Show
        Emmanuel Bourg added a comment - I refreshed the patch on Github: https://github.com/ebourg/qpid/commits/mina-upgrade2 https://github.com/ebourg/qpid/commit/48422d45fb99baa89ef8de8aaa91cf0f417871af
        Hide
        Robbie Gemmell added a comment -

        Hi Emmanuel,

        I hope to incorporate this upgrade into some upcoming work I will be doing. Can I ask if you are already using the patched source with this change in place?

        Robbie

        Show
        Robbie Gemmell added a comment - Hi Emmanuel, I hope to incorporate this upgrade into some upcoming work I will be doing. Can I ask if you are already using the patched source with this change in place? Robbie
        Hide
        Emmanuel Bourg added a comment -

        Thank you Robbie. I don't use the patch, I use a trimmed down client that doesn't rely on Mina.

        Show
        Emmanuel Bourg added a comment - Thank you Robbie. I don't use the patch, I use a trimmed down client that doesn't rely on Mina.
        Robbie Gemmell made changes -
        Assignee Andrew Kennedy [ andrew.kennedy ] Robbie Gemmell [ gemmellr ]
        Fix Version/s 0.13 [ 12316854 ]
        Fix Version/s 0.11 [ 12316272 ]
        Keith Wall made changes -
        Assignee Robbie Gemmell [ gemmellr ] Keith Wall [ k-wall ]
        Hide
        Keith Wall added a comment -

        Hi Robbie

        Emmanuel's patch had gone stale over the last 15 months (removal of inVM, pom dep changes etc). I've created a new patch which achieves the same result against the current codebase.

        cheers Keith

        Show
        Keith Wall added a comment - Hi Robbie Emmanuel's patch had gone stale over the last 15 months (removal of inVM, pom dep changes etc). I've created a new patch which achieves the same result against the current codebase. cheers Keith
        Keith Wall made changes -
        Hide
        Robbie Gemmell added a comment -

        Thanks Emmanuel for the original patch (sorry we didnt get this done earlier), and Keith for the newer one.

        Keith's updated patch is now applied. I noticed just after committing it that the pom dependency stubs still needed to be renamed, so I have also done that.

        Closing this JIRA out now.

        Show
        Robbie Gemmell added a comment - Thanks Emmanuel for the original patch (sorry we didnt get this done earlier), and Keith for the newer one. Keith's updated patch is now applied. I noticed just after committing it that the pom dependency stubs still needed to be renamed, so I have also done that. Closing this JIRA out now.
        Robbie Gemmell made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Keith Wall [ k-wall ] Robbie Gemmell [ gemmellr ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Emmanuel Bourg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development