Qpid
  1. Qpid
  2. QPID-2484

Interoperability tests fail due to attempts to print out contents of JMS Message objects, and do not parse command line properies

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.7
    • Component/s: Java Tests
    • Labels:

      Description

      Interoperability tests fail due to attempts to print out contents of JMS Message objects, as the messages are not considered readable. This is exposed in the toString method, which is called during String concatenation. To fix this, the TestClient and ConversationFactory classes have been modified to print the JMSMessageId instead, which is always accessible. Additionally, the TestClient class does not correctly use parsed command line properties, and fails to set the broker URL and default virtual host name. The default virtual host should be set to "test" in the default properties, to match the Javadoc, and the TestClient should add the parsed command line properties to the default properties with the correct name.

        Activity

        Andrew Kennedy created issue -
        Hide
        Andrew Kennedy added a comment - - edited

        Patch fixes both branch and trunk.

        Show
        Andrew Kennedy added a comment - - edited Patch fixes both branch and trunk.
        Andrew Kennedy made changes -
        Field Original Value New Value
        Attachment 0001-QPID-2484-Fix-interoperability-test-client-branch.patch [ 12441018 ]
        Attachment 0001-QPID-2484-Fix-interoperability-test-client-trunk.patch [ 12441019 ]
        Martin Ritchie made changes -
        Assignee Martin Ritchie [ ritchiem ]
        Andrew Kennedy made changes -
        Attachment 0001-QPID-2484-Fix-interoperability-test-client-trunk.patch [ 12441019 ]
        Martin Ritchie made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Martin Ritchie added a comment -

        Patch applied to the branch only.

        Show
        Martin Ritchie added a comment - Patch applied to the branch only.
        Hide
        Robbie Gemmell added a comment -

        Patch was previously applied to trunk

        Show
        Robbie Gemmell added a comment - Patch was previously applied to trunk
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        22m 1 Martin Ritchie 07/Apr/10 12:36
        In Progress In Progress Resolved Resolved
        123d 4h 42m 1 Robbie Gemmell 08/Aug/10 17:19

          People

          • Assignee:
            Martin Ritchie
            Reporter:
            Andrew Kennedy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development