[QPID-2474] ACL file reader can trip vector iter validity checking

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.7
• Component/s: C++ Broker

Environment

Windows, Visual Studio

• Assignee: Stephen D. Huston
• Reporter: Stephen D. Huston
• Created: 29/Mar/10 20:43
• Updated: 29/Jul/13 18:53
• Resolved: 06/Apr/10 22:00

Description

The ACL file reading can trigger Windows Visual C++ consistency check on vector iterator decrement.

Running the C++ test suite's acl_test starts a broker with options:
--data-dir C:/qpid/trunk/build/src/tests/data_dir --acl-file policy.acl --auth no

This policy.acl file contains only:
acl allow all all

This trips VC checks in qpid::acl::AclReader::loadDecisionData(boost::shared_ptr<qpid::acl::AclData> d=

{...}

) because the 'for' loop at line 92:
for (rlCitr i = rules.end() - 1; cnt; i-, cnt-) {
tries to back i off the beginning of the vector.