Qpid
  1. Qpid
  2. QPID-2472

QpidCompositeRollingAppender log4j configuration is misleading

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5, 0.6
    • Fix Version/s: 0.7
    • Component/s: Java Broker
    • Labels:

      Description

      The QpidCompositeRollingAppender logging appender configuration is misleading. The configuration file states that the default rollover size is 1MB, wheras the actual default in the code is 10 MB. Additionally, the 'CompressBackupFiles' flag controls both the creation of backups in a separate directory on rollover, and the compression of these files. This property should either be renamed or backing up of files to a separate location should be enabled based on the presence of the 'backupFilesToPath' property instead.

        Activity

        Hide
        Andrew Kennedy added a comment -

        Correct the default rollover file size in the log4j XML configuration to match code value of 10 MB

        Show
        Andrew Kennedy added a comment - Correct the default rollover file size in the log4j XML configuration to match code value of 10 MB
        Hide
        Robbie Gemmell added a comment -

        Updating the comment to make it clear that the unconfigured default is 10MB and not 1MB is good, but I think the update to use a 10MB configuration setting is a making it a bit too large and it should be left at 1MB.

        Show
        Robbie Gemmell added a comment - Updating the comment to make it clear that the unconfigured default is 10MB and not 1MB is good, but I think the update to use a 10MB configuration setting is a making it a bit too large and it should be left at 1MB.
        Hide
        Andrew Kennedy added a comment -

        Updated patch with comments changed, for branch and trunk

        Show
        Andrew Kennedy added a comment - Updated patch with comments changed, for branch and trunk
        Hide
        Robbie Gemmell added a comment -

        Patches commited.

        Show
        Robbie Gemmell added a comment - Patches commited.

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Andrew Kennedy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development