Qpid
  1. Qpid
  2. QPID-2262

Random test failures in SimpleACLTest

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5, 0.6
    • Fix Version/s: 0.7
    • Component/s: Java Tests
    • Labels:
      None

      Description

      I have modifed the test to detect when it receives an IllegalStateException and log about QPID-1204 rather than causing a test failure. This approach was already in use when the exception was an AMQAuthenticationException but was not handled when the cause is null.

      1. testout_dec10.tar.gz
        95 kB
        Rajith Attapattu

        Issue Links

          Activity

          Hide
          Rajith Attapattu added a comment -

          In this instance the "testClientPublishInvalidQueueSuccess" test failed with the following error
          Caused an ERROR
          null
          java.lang.NullPointerException
          at org.apache.qpid.server.security.acl.SimpleACLTest.testClientPublishInvalidQueueSuccess(SimpleACLTest.java:445)
          at org.apache.qpid.test.utils.QpidTestCase.runBare(QpidTestCase.java:258)
          at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:321)

          The test output and the broker output is attached.

          Show
          Rajith Attapattu added a comment - In this instance the "testClientPublishInvalidQueueSuccess" test failed with the following error Caused an ERROR null java.lang.NullPointerException at org.apache.qpid.server.security.acl.SimpleACLTest.testClientPublishInvalidQueueSuccess(SimpleACLTest.java:445) at org.apache.qpid.test.utils.QpidTestCase.runBare(QpidTestCase.java:258) at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:321) The test output and the broker output is attached.
          Hide
          Martin Ritchie added a comment -

          Rob has put a patch in to prevent the NPE.

          Show
          Martin Ritchie added a comment - Rob has put a patch in to prevent the NPE.
          Hide
          Martin Ritchie added a comment -

          The reason we get tests with no linked exception is down to QPID-1204.

          We are getting an IllegalStateException rather than the expected AMQAuthenticationException.

          Both exceptions should be thrown depending on the exact threading state of the client however in both situations the correct linked exception should be set. What we find is that when we get an IllegalStateException we do not have the required linked exception.

          Show
          Martin Ritchie added a comment - The reason we get tests with no linked exception is down to QPID-1204 . We are getting an IllegalStateException rather than the expected AMQAuthenticationException. Both exceptions should be thrown depending on the exact threading state of the client however in both situations the correct linked exception should be set. What we find is that when we get an IllegalStateException we do not have the required linked exception.
          Hide
          Martin Ritchie added a comment -

          QPID-2345 can still occur with these tests however it should not be classed as a failure of the test. Logging should occur and when the issues in QPID-2345 have been addressed the if clauses can be removed as there will always be a set linked exception.

          Show
          Martin Ritchie added a comment - QPID-2345 can still occur with these tests however it should not be classed as a failure of the test. Logging should occur and when the issues in QPID-2345 have been addressed the if clauses can be removed as there will always be a set linked exception.
          Hide
          Rajith Attapattu added a comment -

          I will keep an eye on the automated builds to see if there are any failures.

          Show
          Rajith Attapattu added a comment - I will keep an eye on the automated builds to see if there are any failures.
          Hide
          Rajith Attapattu added a comment -

          Haven't seen any failures for a while now.

          Show
          Rajith Attapattu added a comment - Haven't seen any failures for a while now.

            People

            • Assignee:
              Martin Ritchie
              Reporter:
              Rajith Attapattu
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development