Qpid
  1. Qpid
  2. QPID-2243

0-10 protocol connections do not have a matching JMX MBean to allow management

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.15
    • Component/s: Java Broker
    • Labels:

      Description

      0-10 protocol connections do not have a matching JMX MBean to allow management

        Activity

        Robbie Gemmell created issue -
        Robbie Gemmell made changes -
        Field Original Value New Value
        Fix Version/s 0.7 [ 12314455 ]
        Fix Version/s 0.6 [ 12313728 ]
        Hide
        Robbie Gemmell added a comment -

        Updating 'Fix For' to Unknown on issues not targeted for 0.8

        Show
        Robbie Gemmell added a comment - Updating 'Fix For' to Unknown on issues not targeted for 0.8
        Robbie Gemmell made changes -
        Fix Version/s 0.7 [ 12314455 ]
        Andrew MacBean made changes -
        Attachment 0001-IBAMQ-1540-WIP.patch [ 12505145 ]
        Andrew MacBean made changes -
        Assignee Andrew MacBean [ macbean ]
        Andrew MacBean made changes -
        Attachment 0001-IBAMQ-1540-WIP.patch [ 12505145 ]
        Andrew MacBean made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Andrew MacBean made changes -
        Andrew MacBean made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Andrew MacBean added a comment -

        Patch attached for review.

        Show
        Andrew MacBean added a comment - Patch attached for review.
        Andrew MacBean made changes -
        Assignee Andrew MacBean [ macbean ] Robbie Gemmell [ gemmellr ]
        Hide
        Robbie Gemmell added a comment -

        There are unused imports added in ServerConnectionDelegate.java.

        The get/set LastDeclaredQueueName should be removed. It isnt actually used for anything it seems, and so unlike the 0-9 path is actually misleading as it stands. Its a silly concept from the 0-9 path that shouldnt be carried over to 0-10, the field should jsut always display null.

        In the systest, getFirstTransactedChannelId() seems a bit odd given that no non-transactional sessions are ever created and only 1 session per test is used?

        Show
        Robbie Gemmell added a comment - There are unused imports added in ServerConnectionDelegate.java. The get/set LastDeclaredQueueName should be removed. It isnt actually used for anything it seems, and so unlike the 0-9 path is actually misleading as it stands. Its a silly concept from the 0-9 path that shouldnt be carried over to 0-10, the field should jsut always display null. In the systest, getFirstTransactedChannelId() seems a bit odd given that no non-transactional sessions are ever created and only 1 session per test is used?
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Open [ 1 ]
        Assignee Robbie Gemmell [ gemmellr ] Alex Rudyy [ alex.rufous ]
        Hide
        Robbie Gemmell added a comment -

        The new systest also needs to be excluded from the test profiles for the C++ broker.

        Show
        Robbie Gemmell added a comment - The new systest also needs to be excluded from the test profiles for the C++ broker.
        Alex Rudyy made changes -
        Hide
        Alex Rudyy added a comment -

        > There are unused imports added in ServerConnectionDelegate.java.
        Fixed

        > The get/set LastDeclaredQueueName should be removed. It isnt actually used for anything it seems, and so unlike the 0-9 path is actually misleading as it stands. Its a silly concept from the 0-9 path that shouldnt be carried over to 0-10, the field should jsut always display null.

        get/set LastDeclaredQueueName removed

        > In the systest, getFirstTransactedChannelId() seems a bit odd given that no non-transactional sessions are ever created and only 1 session per test is used?

        Tests are changed to have 2 sessions and only one of them is transacted

        Show
        Alex Rudyy added a comment - > There are unused imports added in ServerConnectionDelegate.java. Fixed > The get/set LastDeclaredQueueName should be removed. It isnt actually used for anything it seems, and so unlike the 0-9 path is actually misleading as it stands. Its a silly concept from the 0-9 path that shouldnt be carried over to 0-10, the field should jsut always display null. get/set LastDeclaredQueueName removed > In the systest, getFirstTransactedChannelId() seems a bit odd given that no non-transactional sessions are ever created and only 1 session per test is used? Tests are changed to have 2 sessions and only one of them is transacted
        Alex Rudyy made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Alex Rudyy made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Alex Rudyy added a comment -

        Attached a new patch updated with regards to commentaries.

        Robbie, could you please review it again?

        Show
        Alex Rudyy added a comment - Attached a new patch updated with regards to commentaries. Robbie, could you please review it again?
        Alex Rudyy made changes -
        Assignee Alex Rudyy [ alex.rufous ] Robbie Gemmell [ gemmellr ]
        Hide
        Robbie Gemmell added a comment -

        Patch applied.

        Show
        Robbie Gemmell added a comment - Patch applied.
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Fix Version/s 0.15 [ 12319043 ]
        Resolution Fixed [ 1 ]
        Robbie Gemmell made changes -
        Labels jmx_interface
        Robbie Gemmell made changes -
        Component/s Java Management : JMX Interface [ 12313025 ]
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Reviewable Reviewable Open Open
        1d 23h 51m 1 Robbie Gemmell 01/Dec/11 11:03
        Open Open In Progress In Progress
        724d 18h 28m 2 Alex Rudyy 01/Dec/11 12:12
        In Progress In Progress Reviewable Reviewable
        56s 2 Alex Rudyy 01/Dec/11 12:12
        Reviewable Reviewable Resolved Resolved
        27m 39s 1 Robbie Gemmell 01/Dec/11 12:40
        Resolved Resolved Closed Closed
        1168d 7h 25m 1 Rob Godfrey 11/Feb/15 20:06

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development