Qpid
  1. Qpid
  2. QPID-2243

0-10 protocol connections do not have a matching JMX MBean to allow management

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.15
    • Component/s: Java Broker
    • Labels:

      Description

      0-10 protocol connections do not have a matching JMX MBean to allow management

        Activity

        Hide
        Robbie Gemmell added a comment -

        Updating 'Fix For' to Unknown on issues not targeted for 0.8

        Show
        Robbie Gemmell added a comment - Updating 'Fix For' to Unknown on issues not targeted for 0.8
        Hide
        Andrew MacBean added a comment -

        Patch attached for review.

        Show
        Andrew MacBean added a comment - Patch attached for review.
        Hide
        Robbie Gemmell added a comment -

        There are unused imports added in ServerConnectionDelegate.java.

        The get/set LastDeclaredQueueName should be removed. It isnt actually used for anything it seems, and so unlike the 0-9 path is actually misleading as it stands. Its a silly concept from the 0-9 path that shouldnt be carried over to 0-10, the field should jsut always display null.

        In the systest, getFirstTransactedChannelId() seems a bit odd given that no non-transactional sessions are ever created and only 1 session per test is used?

        Show
        Robbie Gemmell added a comment - There are unused imports added in ServerConnectionDelegate.java. The get/set LastDeclaredQueueName should be removed. It isnt actually used for anything it seems, and so unlike the 0-9 path is actually misleading as it stands. Its a silly concept from the 0-9 path that shouldnt be carried over to 0-10, the field should jsut always display null. In the systest, getFirstTransactedChannelId() seems a bit odd given that no non-transactional sessions are ever created and only 1 session per test is used?
        Hide
        Robbie Gemmell added a comment -

        The new systest also needs to be excluded from the test profiles for the C++ broker.

        Show
        Robbie Gemmell added a comment - The new systest also needs to be excluded from the test profiles for the C++ broker.
        Hide
        Alex Rudyy added a comment -

        > There are unused imports added in ServerConnectionDelegate.java.
        Fixed

        > The get/set LastDeclaredQueueName should be removed. It isnt actually used for anything it seems, and so unlike the 0-9 path is actually misleading as it stands. Its a silly concept from the 0-9 path that shouldnt be carried over to 0-10, the field should jsut always display null.

        get/set LastDeclaredQueueName removed

        > In the systest, getFirstTransactedChannelId() seems a bit odd given that no non-transactional sessions are ever created and only 1 session per test is used?

        Tests are changed to have 2 sessions and only one of them is transacted

        Show
        Alex Rudyy added a comment - > There are unused imports added in ServerConnectionDelegate.java. Fixed > The get/set LastDeclaredQueueName should be removed. It isnt actually used for anything it seems, and so unlike the 0-9 path is actually misleading as it stands. Its a silly concept from the 0-9 path that shouldnt be carried over to 0-10, the field should jsut always display null. get/set LastDeclaredQueueName removed > In the systest, getFirstTransactedChannelId() seems a bit odd given that no non-transactional sessions are ever created and only 1 session per test is used? Tests are changed to have 2 sessions and only one of them is transacted
        Hide
        Alex Rudyy added a comment -

        Attached a new patch updated with regards to commentaries.

        Robbie, could you please review it again?

        Show
        Alex Rudyy added a comment - Attached a new patch updated with regards to commentaries. Robbie, could you please review it again?
        Hide
        Robbie Gemmell added a comment -

        Patch applied.

        Show
        Robbie Gemmell added a comment - Patch applied.

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development