[QPID-1709] configure.ac: make output when no specs are present more friendly?

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: M4
• Fix Version/s: 0.5
• Component/s: C++ Build

Environment

Linux

• Assignee: Unassigned
• Reporter: Stephen D. Huston
• Created: 03/Mar/09 22:27
• Updated: 06/Sep/16 20:27
• Resolved: 04/Mar/09 21:24

Description

This came up on the users list... if a user with a released version of the C++ kit (say, M4) runs configure and it detects that there's no xml spec, all that shows in the output is the error from 'ls' saying there's no xml file. I think it may be better to inform the user of what's going on, with output such as:

...
checking for rpmlint... no
checking for ruby... ruby
configure: AMQP specs not present; source code will not be generated.
checking boost/shared_ptr.hpp usability... yes
...

This is with the following patch to configure.ac:

Index: configure.ac
===================================================================
— configure.ac (revision 749505)
+++ configure.ac (working copy)
@@ -150,8 +150,9 @@

specdir=`pwd`/$srcdir/../specs
AMQP_FINAL_XML=$specdir/amqp.0-10-qpid-errata.xml
+test -f $AMQP_FINAL_XML || AC_MSG_NOTICE([AMQP specs not present; source code will not be generated.])
AC_SUBST(AMQP_FINAL_XML)
-AM_CONDITIONAL([GENERATE], [ls $AMQP_FINAL_XML >/dev/null])
+AM_CONDITIONAL([GENERATE], [test -f $AMQP_FINAL_XML])

1. URL and download URL for the package.
   URL=http://rhm.et.redhat.com/qpidc

What do you think about this in general, and about commiting it for M5?