Qpid
  1. Qpid
  2. QPID-1505

PlainSaslServer throws and immediately catches and wraps Sasl Exception

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: M3, M4, 0.14
    • Fix Version/s: 0.15
    • Component/s: Java Broker
    • Labels:

      Description

      Summary:

      in evaluateResponse Line 94 throws a SaslException saying Authentication Failed but this is then immediately caught on line 97 as SaslException extends IOException. Where by the SaslException is Wrapped in a new SaslException and thrown.

      We probably don't want to do this, something simple like moving the if....else... out of the try...catch would suffice.

        Activity

        Martin Ritchie created issue -
        Rob Godfrey made changes -
        Field Original Value New Value
        Assignee Rob Godfrey [ rgodfrey ]
        Rob Godfrey made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Rob Godfrey made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Rob Godfrey added a comment -

        Robbie - can you review this trivial change for me?

        Show
        Rob Godfrey added a comment - Robbie - can you review this trivial change for me?
        Rob Godfrey made changes -
        Assignee Rob Godfrey [ rgodfrey ] Robbie Gemmell [ gemmellr ]
        Hide
        Robbie Gemmell added a comment -

        Looks good to me.

        Show
        Robbie Gemmell added a comment - Looks good to me.
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Fix Version/s 0.15 [ 12319043 ]
        Resolution Fixed [ 1 ]
        Robbie Gemmell made changes -
        Affects Version/s 0.14 [ 12316855 ]
        Robbie Gemmell made changes -
        Labels starter
        Robbie Gemmell made changes -
        Component/s Starter [ 12312518 ]
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        1174d 1h 51m 1 Rob Godfrey 20/Feb/12 16:01
        In Progress In Progress Reviewable Reviewable
        3s 1 Rob Godfrey 20/Feb/12 16:01
        Reviewable Reviewable Resolved Resolved
        9m 7s 1 Robbie Gemmell 20/Feb/12 16:10
        Resolved Resolved Closed Closed
        1087d 3h 55m 1 Rob Godfrey 11/Feb/15 20:06

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Martin Ritchie
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development