Qpid
  1. Qpid
  2. QPID-1328

Add e2fsprogs-style uuid wrappers for Windows

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: M4
    • Component/s: C++ Broker, C++ Client
    • Labels:
      None

      Description

      The C++ code uses uuid functions that come native on Linux/posix, but not on Windows. The attached patch adds a Linux/posix-like wrapper around the Windows uuid functions.

      1. uuid.diff
        5 kB
        Steve Huston

        Activity

        Hide
        Steve Huston added a comment -

        Good point, Alan - I've made that change and committed; svn revision 702917

        Show
        Steve Huston added a comment - Good point, Alan - I've made that change and committed; svn revision 702917
        Hide
        Alan Conway added a comment -

        I'd be inclined to rename sys/Uuid.h as sys/uuid.h since it doesn't contain a class sys::Uuid, otherwise it loos good to me.

        Show
        Alan Conway added a comment - I'd be inclined to rename sys/Uuid.h as sys/uuid.h since it doesn't contain a class sys::Uuid, otherwise it loos good to me.
        Hide
        Steve Huston added a comment -

        This patch also should include a Makefile.am addition for qpid/sys/Uuid.h but adding it would confuse things since I have more than one jira's changes in my svn workspace - there will be a corresponding addition of qpid/sys/Uuid.h to Makefile.am, nobase_include_HEADERS.

        Please review and let me know of any issues.

        Show
        Steve Huston added a comment - This patch also should include a Makefile.am addition for qpid/sys/Uuid.h but adding it would confuse things since I have more than one jira's changes in my svn workspace - there will be a corresponding addition of qpid/sys/Uuid.h to Makefile.am, nobase_include_HEADERS. Please review and let me know of any issues.

          People

          • Assignee:
            Steve Huston
            Reporter:
            Steve Huston
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development