[PYLUCENE-38] JCC build error under recents versions of clang.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Environment: macOS
• Assignee: Unassigned
• Reporter: A. Coady
• Created: 17/Oct/17 21:29
• Updated: 26/May/18 00:38
• Resolved: 18/Oct/17 02:40

Description

jcc3/sources/JArray.cpp:315:66: error: ordered comparison between pointer and zero ('PyObject *' (aka '_object *') and 'int')
        PyList_Type.tp_as_sequence->sq_inplace_concat(list, arg) < 0)
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
jcc3/sources/JArray.cpp:330:64: error: ordered comparison between pointer and zero ('PyObject *' (aka '_object *') and 'int')
        PyList_Type.tp_as_sequence->sq_inplace_repeat(list, n) < 0)
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

Comparisons between NULL and integers have been elevated from a warning to an error in recent versions of clang. And presumably the error handling wasn't working anyway.