[PROTON-975] connecting with DIGEST-MD5 fails if buffer containing outcome and first encrypted frame is received

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: proton-0.10
• Fix Version/s: proton-0.10
• Component/s: proton-c
• Assignee: Andrew Stitcher
• Reporter: Ken Giusti
• Created: 05/Aug/15 17:57
• Updated: 07/Jan/16 12:14
• Resolved: 11/Aug/15 19:02

Description

I'm hitting an occasional client crash when using an DIGEST-MD5 SASL mech to talk to the qpidd broker.

I've built the broker using the 0.10rc1 as the proton library.

I'm using a pyngus based client. I will upload this reproducer.

Best I can tell, the client pushes a single buffer to the transport that contains both the SASL outcome frame from qpidd and the first encrypted frame. SASL does not handle this case correctly and attempts to parse the encrypted frame as cleartext.

I will open another bug against the frame decode to prevent parsing invalid frames.

Issue Links

• is related to: PROTON-976 pn_read_frame does not validate frame offset