Qpid Proton
  1. Qpid Proton
  2. PROTON-97

RELEASED disposition not processed by engine

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.1
    • Fix Version/s: 0.5
    • Component/s: proton-c
    • Labels:
      None

      Description

      When the proton-c engine receives a disposition with a RELEASED state, it prints a non-log message "default 38" in the default clause of a switch (see pn_do_disposition) in engine.c.

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1493859 from rhs@apache.org
        [ https://svn.apache.org/r1493859 ]

        extended the delivery API to work with all delivery states defined by the transport spec as well as custom delivery states. This addresses PROTON-97 and the C portion of PROTON-75

        Show
        ASF subversion and git services added a comment - Commit 1493859 from rhs@apache.org [ https://svn.apache.org/r1493859 ] extended the delivery API to work with all delivery states defined by the transport spec as well as custom delivery states. This addresses PROTON-97 and the C portion of PROTON-75
        Hide
        Gordon Sim added a comment -

        Note that the change above breaks the API which may be worth highlighting in release notes. (This does also mean that the qpid::messaging and qpidd plugins that have proton as a dependency can't build against proton trunk).

        Show
        Gordon Sim added a comment - Note that the change above breaks the API which may be worth highlighting in release notes. (This does also mean that the qpid::messaging and qpidd plugins that have proton as a dependency can't build against proton trunk).
        Hide
        Rafael H. Schloming added a comment -

        What's the extent/consequences of the breakage? I was aware that it was an API change, but I wasn't sure how much that would matter. If there's good reason I could look at trying to maintain more compatibility. Off the top of my head there might be some macro magic we could do, but it would take some exploration to figure out what's possible.

        Show
        Rafael H. Schloming added a comment - What's the extent/consequences of the breakage? I was aware that it was an API change, but I wasn't sure how much that would matter. If there's good reason I could look at trying to maintain more compatibility. Off the top of my head there might be some macro magic we could do, but it would take some exploration to figure out what's possible.
        Hide
        Gordon Sim added a comment -

        The extent is small, as far as I can see only the type being undefined and the various tests on it changing to methods. The consequence is simply that at this stage I can't yet convert trunk for the components I am working on to use the trunk from proton as it is not released (and if I modified it to work with the latest API, it would not compile against the last released API). Once 0.5 comes out I'll switch over of course. I could also add macros to handle both versions in my code, but it doesn't seem worth it at this point. The comment was mainly just to point out the change in case it had been forgotten.

        Show
        Gordon Sim added a comment - The extent is small, as far as I can see only the type being undefined and the various tests on it changing to methods. The consequence is simply that at this stage I can't yet convert trunk for the components I am working on to use the trunk from proton as it is not released (and if I modified it to work with the latest API, it would not compile against the last released API). Once 0.5 comes out I'll switch over of course. I could also add macros to handle both versions in my code, but it doesn't seem worth it at this point. The comment was mainly just to point out the change in case it had been forgotten.

          People

          • Assignee:
            Rafael H. Schloming
            Reporter:
            Ted Ross
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development