Uploaded image for project: 'Qpid Proton'
  1. Qpid Proton
  2. PROTON-957

[proton-j] make trace logging of transfer frames more useful

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: proton-0.9.1
    • Fix Version/s: proton-0.10
    • Component/s: proton-j
    • Labels:
      None

      Description

      In proton-C, the number of payload bytes in the transfer are always reported, then a fixed maximum 1024 char string containing stringified payload is shown, and the string is appended with "...(truncated)" whenever it doesnt contain the full payload.

      In Proton-J, the entire payload is toString'ed and then a much smaller semi-fixed (its configurable via system property) maximum 80chars of stringified payload is shown, and if this is not the full string then the total number of characters in the string is displayed. This gives you no usable idea of how many bytes are in the remaining or overall payload since each byte uses 1 or 4chars to display.

      To make things more aligned and more usable, the output should be updated to be more like proton-c, logging the total payload size in the transfer first, then the stringified content which should be increased in length to match proton-c, which will make it more usable since it currently only tends to show part of the header/properties sections and gets nowhere near the actual body section bytes of the message.

        Attachments

          Activity

            People

            • Assignee:
              robbie Robbie Gemmell
              Reporter:
              robbie Robbie Gemmell
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: