[PROTON-946] remove generated data structure definitions from protocol.h

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: proton-0.10
• Fix Version/s: proton-c-future
• Component/s: proton-c
• Assignee: Unassigned
• Reporter: Michael Goulish
• Created: 13/Jul/15 18:03
• Updated: 21/Nov/16 14:01

Description

Currently protocol.h.py reads the AMQP 1.0 spec xml files and generates all of its output into protocol.h – even the data structure definitions.

Those definitions are currently protected by #ifdef DEFINE_FIELDS , which is defined only in codec.c – so the definitions only show up in that file, while other .c files only see the declarations.

If DEFINE_FIELDS is #defined in any other file, compilation will fail with multiple definition errors.

The structure declarations should remain in the .h file , but the actual definitions should be moved into a generated .c file.