[PROTON-919] make C impl behave like java wrt channel_max error

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: proton-0.10
• Component/s: proton-c, python-binding
• Assignee: Michael Goulish
• Reporter: Michael Goulish
• Due: 22/Jun/15
• Created: 23/Jun/15 17:59
• Updated: 17/Jul/15 14:46
• Resolved: 17/Jul/15 14:46

Description

In the Java impl, I made TransportImpl throw an exception if the application tries to change the local channel_max setting after we have already sent the OPEN frame to the remote peer. ( Because at that point we communicate our channel_max limit to the peer – no fair changing it afterwards.)

One reviewer suggested that it would be nice if the C impl worked the same way. That would mean that pn_set_channel_max() would have to return a result code, which the Python binding would detect – Python binding throws exception, python tests detect it – so it would work same way as Java.