[PROTON-491] proton-c: Messenger uses hard-coded link names of sender-xxx & receiver-xxx

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: proton-0.6
• Component/s: proton-c
• Labels: easyfix messenger
• Assignee: Rafael H. Schloming
• Reporter: Dominic Evans
• Created: 23/Jan/14 12:02
• Updated: 20/Oct/17 22:13
• Resolved: 20/Oct/17 22:13

Description

1. Abstract

The qpid-proton 'messenger' implementation currently uses hard-coded receiver-xxx and sender-xxx link names for all attachments.

1. Description

I believe the AMQP 1.0 spec says here that:- although client-ids do not need to be unique, the triplet of <client-id>, <link-name> and <server-id>  is guaranteed to be unique.

http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#doc-idp298752

However, the qpid-proton Messenger code seems to have all link-name's hard-coded to sender-xxx and receiver-xxx

As an easyfix, I would suggest that by default the topicname part of the address should be appended to the link-name (instead of -xxx)

e.g., amqp://localhost/topicName --> sender-topicName / receiver-topicName

However, that would still cause a clash if the same messenger wanted to make two subscriptions to the same topic, so perhaps the Messenger implementation needs to track what link names it has allocated and ensure a unique name is assigned each time?

Issue Links

• is duplicated by: PROTON-924 links are not uniquely named by messenger