Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Duplicate
-
proton-0.5
-
None
-
None
-
GCC 4.4.7
Description
Hi Folks,
In our project, we currently use the following compiler flags for gcc (tested in version 4.4.7):
-Wall -Wdeclaration-after-statement -Wmissing-prototypes -Wstrict-prototypes -Werror
Unfortunately this causes problems in recent versions of proton as its headers produce some warnings of their own. The ones we have spotted can be recreated using the following code:
#include <proton/error.h>
#include <proton/messenger.h>
int main(){}
Compiled with:
$ gcc -Wall -Wdeclaration-after-statement -Wmissing-prototypes -Wstrict-prototypes -Werror -I./qpid-proton-0.5/proton-c/include/ test.c -o test
cc1: warnings being treated as errors
In file included from test.c:1:
./qpid-proton-0.5/proton-c/include/proton/error.h:46: error: function declaration isn’t a prototype
In file included from test.c:2:
./qpid-proton-0.5/proton-c/include/proton/messenger.h:458:29: error: "/*" within comment
./qpid-proton-0.5/proton-c/include/proton/messenger.h:466:40: error: "/*" within comment
./qpid-proton-0.5/proton-c/include/proton/messenger.h:470:32: error: "/*" within comment
./qpid-proton-0.5/proton-c/include/proton/messenger.h:475:34: error: "/*" within comment
test.c:4: error: function declaration isn’t a prototype
The first one can be resolved by changing pn_error() to pn_error(void) and the others can be fixed simply by adding some spacing. We typically just hack our local copies for testing, but we figured it may be better to get this into the main code stream if you guys can find the time to put it in.
Cheers,
Frank
Attachments
Issue Links
- duplicates
-
PROTON-420 Warnings Presented When Using Strict Compiler Flags
- Closed