[PROTON-336] pn_messenger_put does not clear PN_OVERFLOW error after expanding its buffer

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.3
• Fix Version/s: proton-0.5
• Component/s: proton-c
• Assignee: Rafael H. Schloming
• Reporter: Rob Percival
• Created: 13/Jun/13 10:04
• Updated: 07/Jan/16 11:33
• Resolved: 21/Aug/13 15:16

Description

In pn_messenger_put, the buffer is initialised to an array of 1024 bytes. It then tries to encode the message and if it won't fit, a PN_OVERFLOW error occurs (against the message). The buffer is then doubled in size and it retries encoding. However, the PN_OVERFLOW error is not cleared. This means that after pn_messenger_put returns successfully, calling pn_message_errno will report that a PN_OVERFLOW error occurred. The error message, unhelpfully, is "data error: (null)".