Qpid Proton
  1. Qpid Proton
  2. PROTON-270

Make artifactId for proton tests more descriptive

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.4
    • Fix Version/s: 0.5
    • Component/s: None
    • Labels:
      None

      Description

      As raised by Robbie on the proton list (http://mail-archives.apache.org/mod_mbox/qpid-proton/201303.mbox/%3cCAFitrpTig+TzL-tSVjOp1qDtU74MXwZqxG_LwLYSdNfV9SqMhw@mail.gmail.com%3e)

      Hi all,

      I just noticed the maven artifactId for the proton tests for 0.4:

      <dependency>
      <groupId>org.apache.qpid</groupId>
      <artifactId>tests</artifactId>
      <version>0.4</version>
      </dependency>

      Can we add 'proton' to that Id for consistency with all the other
      artifacts, and perhaps also help clue users in on what they actually are?

        Activity

        Hide
        Keith Wall added a comment -

        I would be in favour of changing the groupId used by proton from "org.apache.qpid" to "org.apache.qpid.proton" in order to clearly differentiate proton modules for other qpid modules. I think this would follow the structure suggested by http://maven.apache.org/guides/mini/guide-naming-conventions.html

        Any thoughts from anyone else?

        Show
        Keith Wall added a comment - I would be in favour of changing the groupId used by proton from "org.apache.qpid" to "org.apache.qpid.proton" in order to clearly differentiate proton modules for other qpid modules. I think this would follow the structure suggested by http://maven.apache.org/guides/mini/guide-naming-conventions.html Any thoughts from anyone else?
        Hide
        Robbie Gemmell added a comment -

        I dont particularly mind the group id, as I think the artifact id is likely going to have to contain proton in order to differentiate the jar names from other projects (or parent projects), meaning either way works for the groupId.

        My only real interest in this was that at some point we should end up with naming being somewhat consistent between releases and between artifacts. Thus far it seems like almost every release of proton-j has had different artifact names than the last, which makes it slightly harder for users to track new releases and clutters up search results (try searching for qpid artifacts and you also get some old proton results, then search for proton and you get a mixture of current and once or twice defunct proton artifacts names).

        Show
        Robbie Gemmell added a comment - I dont particularly mind the group id, as I think the artifact id is likely going to have to contain proton in order to differentiate the jar names from other projects (or parent projects), meaning either way works for the groupId. My only real interest in this was that at some point we should end up with naming being somewhat consistent between releases and between artifacts. Thus far it seems like almost every release of proton-j has had different artifact names than the last, which makes it slightly harder for users to track new releases and clutters up search results (try searching for qpid artifacts and you also get some old proton results, then search for proton and you get a mixture of current and once or twice defunct proton artifacts names).
        Hide
        ASF subversion and git services added a comment -

        Commit 1510949 from Philip Harvey in branch 'proton/trunk'
        [ https://svn.apache.org/r1510949 ]

        PROTON-270: make tests module name more descriptive

        Show
        ASF subversion and git services added a comment - Commit 1510949 from Philip Harvey in branch 'proton/trunk' [ https://svn.apache.org/r1510949 ] PROTON-270 : make tests module name more descriptive

          People

          • Assignee:
            Philip Harvey
            Reporter:
            Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development