[PROTON-2272] [c] Threadercizer build causes warnings and hence build failures on 32 bit builds

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: proton-c-0.32.0
• Fix Version/s: proton-c-0.33.0
• Component/s: proton-c
• Labels: release-notes
• Assignee: Unassigned
• Reporter: Andrew Stitcher
• Created: 21/Aug/20 21:41
• Updated: 25/Nov/20 15:41
• Resolved: 21/Aug/20 21:43

Description

When building threadercizer for a 32 bit architecture using the default setting will cause a warning will be treated as an error:

(this is from a build on Raspbian)

[1/5] Building C object c/tests/CMakeFiles/c-threaderciser.dir/threaderciser.c.o
FAILED: c/tests/CMakeFiles/c-threaderciser.dir/threaderciser.c.o 
/usr/bin/cc  -I/home/andrew/Coding/qpid-proton/src/c/include -I/home/andrew/Coding/qpid-proton/src/c/src -Ic/include -Ic/src -Ic/tests -I/home/andrew/Coding/qpid-proton/src/tests/include -fvisibility=hidden -O2 -g -DNDEBUG    -Werror -Wall -pedantic-errors -Wstrict-prototypes -Wvla -Wsign-compare -Wwrite-strings -std=c99 -MD -MT c/tests/CMakeFiles/c-threaderciser.dir/threaderciser.c.o -MF c/tests/CMakeFiles/c-threaderciser.dir/threaderciser.c.o.d -o c/tests/CMakeFiles/c-threaderciser.dir/threaderciser.c.o   -c /home/andrew/Coding/qpid-proton/src/c/tests/threaderciser.c
/home/andrew/Coding/qpid-proton/src/c/tests/threaderciser.c: In function ‘debug_impl’:
/home/andrew/Coding/qpid-proton/src/c/tests/threaderciser.c:97:45: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Werror=format=]
   i += assert_no_err(snprintf(i, end-i, "(%lx) ", (uintptr_t) pthread_self()));
                                           ~~^     ~~~~~~~~~~~~~~~~~~~~~~~~~~
                                           %x
cc1: all warnings being treated as errors

This issue has already been fixed for 0.33.

It has a good workaround in 0.32 by giving -DENABLE_WARNING_ERROR=off to cmake. This should be release noted for 0.32

Issue Links

• is caused by: PROTON-2268 Threadercizer causes warnings on BSD based platforms
• is fixed by: PROTON-2268 Threadercizer causes warnings on BSD based platforms