[PROTON-2187] Python client leak on early Connection.close

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-c-0.28.0
• Fix Version/s: proton-c-0.31.0
• Component/s: python-binding
• Assignee: Clifford Jansen
• Reporter: Clifford Jansen
• Created: 26/Mar/20 20:52
• Updated: 14/May/20 09:30
• Resolved: 30/Mar/20 07:09

Description

The Python client waits for completion of the outgoing TCP connection handshake before it fully configures its internal IO structures for the connection to do normal two way communication with the server. If a Connection.close() happens before the TCP handshake is complete, the incomplete nature of the IO setup is not properly taken into account on close and cleanup, resulting in leaked memory related to the Container and the Connection.

The window for this problem is usually small, but not insignificant on some networks. It is trivial to reproduce if firewall tables are set up to drop packets.

See reproducer https://bugzilla.redhat.com/show_bug.cgi?id=1810549#c3

The bug also reproduces against the Proton example brokers. qpidd is not required.

Issue Links

• links to: GitHub Pull Request #236