[PROTON-2123] Proton can produce invalid utf-8 in PN_TRACE_FRM=1 logs

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-c-0.29.0
• Component/s: proton-c
• Environment: macOS 10.14, when running qdrouterd tests
• Assignee: Jiri Daněk
• Reporter: Jiri Daněk
• Created: 21/Oct/19 13:03
• Updated: 23/Oct/19 22:18
• Resolved: 23/Oct/19 22:18

Description

As discovered on DISPATCH-1384, qdrouterd can sometimes produce invalid utf-8 in TRACE output.

https://issues.apache.org/jira/browse/DISPATCH-1384?focusedCommentId=16955281&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16955281

It may look like this

2019-10-21 01:46:38.790093 -0700 SERVER (trace) [3]:0 <- @transfer(20) [handle=1, delivery-id=0, delivery-tag=b"\x01\x00\x00\x00\x00\x00\x00\x00", message-format=0, settled=true] (228) "\x00Sp<D0>\x00\x00\x00\x05\x00\x00\x00\x01B\x00Sr<D1>\x00\x00\x00U\x00\x00\x00\x08<A3>\x0ex-opt-qd.trace<D0>\x00\x00\x00\x09\x00\x00\x00\x01<A1>\x030/B<A3>\x10x-opt-qd.ingress<A1>\x030/B<A3>\x09x-opt-qd.<A1>\x01X<A3>\x09x-opt-qd.<A1>\x01X\x00Ss<D0>\x00\x00\x00\x1f\x00\x00\x00\x06@@<A1>\x14amqp:/_local/qdhello@@@\x00St<D1>\x00\x00\x00\x13\x00\x00\x00\x02<A1>\x06opcode<A1>\x05HELLO\x00Sw<D1>\x00\x00\x000\x00\x00\x00\x0a<A1>\x02id<A1>\x01B<A1>\x02pvT\x01<A1>\x04area<A1>\x010<A1>\x08instanceq]<AD>pm<A1>\x04seenE" (/Users/cloud-user/repos/qpid/qpid-dispatch/src/server.c:107)

The <D0> and so on is how less deals with such characters.

I'd expect to see \xd0 etc. instead.

Issue Links

• blocks: DISPATCH-1384 Fix tests in Travis CI on macOS
• links to: GitHub Pull Request #197