[PROTON-2077] Change Minimum supported Visual Studio compiler to 2015

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-c-0.27.0
• Fix Version/s: proton-c-0.32.0
• Component/s: build
• Assignee: Andrew Stitcher
• Reporter: Jiri Daněk
• Created: 22/Jul/19 14:56
• Updated: 26/Aug/20 17:24
• Resolved: 10/Jul/20 21:39

Description

The primary goal here is so we can change the project C support to C99 everywhere.

So we need to ensure that all the C Windows code is actually C99 or actually compile it as C++.

Because snprintf is only supported in Visual Studio 2015. Using snprintf is the best fix for the buffer overrun in pn_proactor_addr, as per https://github.com/apache/qpid-proton/pull/176

Also, printf supports %zu for printing size_t (since Visual Studio 2013).

Does anyone use anything older than Visual Studio 2015 with Proton, at this point?

Issue Links

• is related to: PROTON-2080 cc1plus: warning: -Wformat-security ignored without -Wformat [-Wformat-security]
• is related to: PROTON-2207 Proton-c clients cannot really be compiled with strict C89 with gnu compatible compilers
• is related to: PROTON-2208 Change base C language/compiler requirements to C99 or equivalent
• links to: GitHub Pull Request #185