Uploaded image for project: 'Qpid Proton'
  1. Qpid Proton
  2. PROTON-2031

CMake files for find_package() in /lib64/cmake/Proton/ProtonConfig.cmake should log a message

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: proton-c-0.27.0
    • Fix Version/s: None
    • Component/s: proton-c
    • Labels:
      None

      Description

      Currently, Qpid Dispatch does

      find_package(Proton 0.23 REQUIRED COMPONENTS Core Proactor)
      message(STATUS "Found Proton: ${Proton_LIBRARIES} (found version \"${Proton_VERSION}\")" )

      but that message() should not be necessary. Instead, Proton's /lib64/cmake/Proton/ProtonConfig.cmake and /lib64/cmake/ProtonCpp/ProtonCppConfig.cmake files should each be taking care of printing that, unless the QUIET flag is specified https://cmake.org/cmake/help/v2.8.12/cmake.html#command:find_package

      Adding the message to Proton would mean Dispatch compilation will print the same message twice. I think that is acceptable temporary state.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jdanek Jiri Daněk
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: