[PROTON-1854] [Python binding] Using message properties under Python 3 generates NameError 'unicode'

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: proton-c-0.24.0
• Assignee: Andrew Stitcher
• Reporter: Kim van der Riet
• Created: 06/Jun/18 13:41
• Updated: 30/Jun/18 15:23
• Resolved: 06/Jun/18 17:25

Description

The Qpid Interop Test jms_hdrs_props test triggers this error under part C and part D of the test which include message properties. When this test runs under Python 3, these tests fail.

msg = proton.Message()
msg.properties['key'] = value
event.sender.send(msg)

which produces the following error:

01:34:49   File "/var/lib/jenkins/workspace/insta01:34:49   File "/var/lib/jenkins/workspace/install/libexec/qpid_interop_test/shims/qpid-proton-python/jms_hdrs_props_test/Sender.py", line 120, in _send_test_values 
01:34:49     event.sender.send(message) 
01:34:49   File "/var/lib/jenkins/workspace/install/lib64/proton/bindings/python3/proton/_endpoints.py", line 615, in send 
01:34:49     return obj.send(self, tag=tag) 
01:34:49   File "/var/lib/jenkins/workspace/install/lib64/proton/bindings/python3/proton/_message.py", line 416, in send 
01:34:49     encoded = self.encode() 
01:34:49   File "/var/lib/jenkins/workspace/install/lib64/proton/bindings/python3/proton/_message.py", line 399, in encode 
01:34:49     self._pre_encode() 
01:34:49   File "/var/lib/jenkins/workspace/install/lib64/proton/bindings/python3/proton/_message.py", line 137, in _pre_encode 
01:34:49     self._check_property_keys() 
01:34:49   File "/var/lib/jenkins/workspace/install/lib64/proton/bindings/python3/proton/_message.py", line 113, in _check_property_keys 
01:34:49     if isinstance(k, unicode): 
01:34:49 NameError: name 'unicode' is not defined

 

Issue Links

• is caused by: PROTON-1850 [Python] Split up monolithic proton __init__.py