[PROTON-1611] cmake fails if g++ not installed

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-c-0.18.0
• Fix Version/s: proton-c-0.18.0
• Component/s: build, cpp-binding
• Environment: "clean" centos docker image docker.io/centos:latest
• Assignee: Andrew Stitcher
• Reporter: Ken Giusti
• Created: 04/Oct/17 14:49
• Updated: 24/Oct/17 08:44
• Resolved: 17/Oct/17 14:34

Description

While testing the 0.18 proton beta I created a stock centos docker container and followed the instructions in the INSTALL.md file, installing all the documented dependencies.

cmake failed with:

cmake .. -DCMAKE_INSTALL_PREFIX=/usr
CMake Error at /usr/share/cmake/Modules/CMakeDetermineCompilerId.cmake:446 (execute_process):
execute_process given COMMAND argument with no value.
Call Stack (most recent call first):
/usr/share/cmake/Modules/CMakeDetermineCompilerId.cmake:48 (CMAKE_DETERMINE_COMPILER_ID_VENDOR)
/usr/share/cmake/Modules/CMakeDetermineCXXCompiler.cmake:127 (CMAKE_DETERMINE_COMPILER_ID)
CMakeLists.txt:24 (enable_language)

– The CXX compiler identification is unknown
– Build type is "RelWithDebInfo" (has debug symbols)
– PN_VERSION: 0.18.0 (beta)
– Can't locate the valgrind command; no run-time error detection
– Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
– Building the epoll proactor
– Node.js (http://nodejs.org) is not installed: can't build JavaScript binding
– Could NOT find Ruby (missing: RUBY_EXECUTABLE RUBY_INCLUDE_DIR RUBY_LIBRARY)
– Could NOT find Perl (missing: PERL_EXECUTABLE)
– Could NOT find Perl (missing: PERL_EXECUTABLE)
– Could NOT find PerlLibs (missing: PERL_LIBRARY PERL_INCLUDE_PATH)
– Trying alternative search for Perl
– Looking for
– No Perl devel environment found - skipping Perl bindings
– The tox tool is not available; skipping the python-tox-tests
– Configuring incomplete, errors occurred!
See also "/root/qpid-proton-0.18.0-beta/BUILD/CMakeFiles/CMakeOutput.log".
See also "/root/qpid-proton-0.18.0-beta/BUILD/CMakeFiles/CMakeError.log".

Had to ' yum install gcc-c++' in order to get cmake generation to succeed.

Either the INSTALL.md needs to list gcc-c++ for a required dep, or the cmake scripts need to avoid building the c++ binding if no c++ compiler is installed.

Did not test but suspect ubuntu build may fail in a similar fashion.