Uploaded image for project: 'Qpid Proton'
  1. Qpid Proton
  2. PROTON-1372

Use PIMPL, not an interface, for event_loop

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • proton-0.14.0
    • proton-0.16.0
    • cpp-binding
    • None

    Description

      This represents the event_loop aspect of the work below.


      Original issue description:

      If you have a libqpid-proton-cpp compiled with C++11 and then link to it using a C++03 and use the proton::container::schedule API then the application will crash. This is because there is an extra virtual function present in the middle of the C++11 vtable compared to the C++03 vtable. So that when used from '03 the wrong member function gets called.

      The extra member function is present because of conditional compilation dependent on the C++ version doing the compilation.

      This should also be a problem the other way round too, so using a libqpid-proton-cpp compiled with C++03 from C++11 will cause there to be one fewer entry in the vtable, and using schedule will either get the wrong version of schedule or call an entry of the end of the vtable.

      Attachments

        Issue Links

          Activity

            People

              astitcher Andrew Stitcher
              astitcher Andrew Stitcher
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: