[PROTON-1226] Handler not set on inbound connection

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.13.0, proton-0.14.0
• Fix Version/s: proton-0.13.0
• Component/s: cpp-binding
• Assignee: Clifford Jansen
• Reporter: Clifford Jansen
• Created: 03/Jun/16 19:11
• Updated: 06/Jun/16 15:29
• Resolved: 06/Jun/16 15:29

Description

Historically, the handler was always specified before the connection was created so that the PN_CONNECTION_INIT could go to the correct handler, whereas the rest of the connection options could only be applied later, after creation.

For inbound connections, the handler was set on the listener (pn_reactor_acceptor()) and the reactor set it for the accepted connections.

History has changed. Nobody processes PN_CONNECTION_INIT except the global handler, so deferred setting of the handler is probably OK, allowing the handler to be set at the same time as the other non-transport options.

Alternatively, the caller of on_accept() must separately apply the handler (which might change per connection on a listener) to make the new listen_handler interface work as intended.