[PROTON-1131] Improve URL parsing for usernames containing an at "@" sign

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Fix Version/s: proton-c-future
• Component/s: proton-c
• Assignee: Unassigned
• Reporter: Thomas Conté
• Created: 08/Feb/16 09:51
• Updated: 04/Nov/16 22:42

Description

In the case the username being passed via the URL contains an at sign ("@") (e.g. during SASL PLAIN authentication), the URL parsing will fail because it will take the first at sign as the mark of the host name start.

Example URL:

amqps://[e-mail]:[e-mail]/devices/myFirstDevice/messages/events

In this case the user name is "[e-mail]".

Suggested fix: use strrchr() instead of strchr() in order to match the last occurence of an at sign, marking the start of the host name.

$ diff ./util.c ~/qpid-proton/proton-c/src/util.c
167c167
< char *at = strchr(url, '@');
—
> char *at = strrchr(url, '@');