[PROTON-1128] [C++ binding] Symbol exports use wrong directive for proton::condition

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: proton-0.12.0
• Fix Version/s: proton-0.13.0
• Component/s: cpp-binding
• Assignee: Andrew Stitcher
• Reporter: Andrew Stitcher
• Created: 04/Feb/16 19:20
• Updated: 17/Jun/16 13:35
• Resolved: 09/Feb/16 15:38

Description

The C++ binding API header file incorrectly uses PN_CPP_EXPORT rather than PN_CPP_EXTERN.

In theory on Windows (the only system where these directives are currently active) this could mean that user programs using the proton::condition API would be unable to do so as the program would be exporting the API rather than importing it.

However in limited tests using VS 2015 it doesn't seem to actually be causing a problem.

It may be that it is problematic in other (earlier) VS compilers.