[PROTON-1093] [proton-c++] pragma to hide a warning in GCC introduces a warning in Windows

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.12.0
• Fix Version/s: proton-0.12.0
• Component/s: cpp-binding
• Environment: Visual Studio 20xx
• Assignee: Charles E. Rolke
• Reporter: Charles E. Rolke
• Created: 06/Jan/16 20:04
• Updated: 16/Feb/16 14:57
• Resolved: 07/Jan/16 13:49

Description

proton-c\bindings\cpp\src\contexts.cpp(48) : warning C4068: unknown pragma
#pragma GCC diagnostic ignored "-Wold-style-cast"

commit fd52a33

I propose fixing this by moving the pragma into cmake to leave the source with no #pragma and with no conditional to hide the pragma.

Windows has plenty of other warnings if we're serious about squelching them.