[PROTON-1045] Use of callbacks to handle accepted endpoints violates design goals.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.11.0
• Fix Version/s: proton-0.12.0
• Component/s: go-binding
• Assignee: Alan Conway
• Reporter: Alan Conway
• Created: 11/Nov/15 15:35
• Updated: 16/Feb/16 14:58
• Resolved: 12/Nov/15 18:50

Description

The electron.Connectoin takes an "accept" callback function to process incoming endpoint requests (sessions, links) This violates the original design goal to have no user code called in the proton goroutine. It relies on the user knowing which functions they are allowed to call in the callback since many user-facing functions can deadlock if called in the proton goroutine.

Fix this by having proton provide Incoming requests to the user via a channel. This is also more consistent with typical use of the go net package: when there is something to accept, you start a goroutine to do it, you don't register a callback.