[PROTON-1043] Possible typo in messenger.c

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: proton-c-0.18.0
• Component/s: proton-c
• Labels: messenger
• Assignee: Andrew Stitcher
• Reporter: Alan Conway
• Created: 09/Nov/15 16:47
• Updated: 24/Oct/17 08:44
• Resolved: 06/Oct/17 21:59

Description

From mailing list: http://qpid.2158936.n2.nabble.com/Possible-typo-in-messenger-c-td7632895.html

---

Is this an error:

if (messenger->flags | PN_FLAGS_CHECK_ROUTES) {
(line 1498 in messenger.c)?

Shouldn't it be:
if (messenger->flags & PN_FLAGS_CHECK_ROUTES) {

---

In my opinion this comment is correct but I'm not an expert on messenger so wary of fixing without knowing if some of the code controlled by the if statement really should be running even if PN_FLAGS_CHECK_ROUTES is off. Clearly the code is incorrect as it stands I'm just uncertain if the fix suggested is safe or if the code needs review.

Issue Links

• is related to: PROTON-988 pn_messenger_set_flags does not support new SASL flag correctly