[PORTLETBRIDGE-157] NullPointerException from Bridge encodeActionUrl when use portlet: syntax

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0, 2.0.0-alpha
• Fix Version/s: 1.0.1, 2.0.0-beta
• Assignee: Michael Freedman
• Reporter: Michael Freedman
• Created: 29/Jul/10 15:29
• Updated: 29/Jul/10 16:02
• Resolved: 29/Jul/10 16:02

Description

When you use the portlet: syntax in an url passed to encodeActionURL the bridge determines whether its a faces view target by looking one of 2 special query string parameters (one indicates the viewId the other the viewPath). If there is no viewId and no viewPath a nullPointerException is thrown. This is because the if statement surrounding the viewPath check looks to see if the viewId string is null before derefercing the viewPath string.

I.e. the code is
else if (s != null && s1.equals(Bridge.FACES_USE_CURRENT_VIEW_PARAMETER))

but should be

else if (s1 != null && s1.equals(Bridge.FACES_USE_CURRENT_VIEW_PARAMETER))