[POOL-338] GenericObjectPool constructor may throw an exception under OSGi

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.2, 2.4.3, 2.5.0
• Fix Version/s: 2.6.0

Environment

Java 8, Liferay DXP (an OSGi environment).

• Assignee: Gary D. Gregory
• Reporter: Michael C
• Created: 04/Apr/18 18:51
• Updated: 28/May/18 13:47
• Resolved: 27/May/18 16:18

Description

Version 2.4.3 GenericObjectPool constructor throws this exception:

java.lang.IllegalArgumentException: [org.apache.commons.pool2.impl.DefaultEvictionPolicy] does not implement EvictionPolicy
    at org.apache.commons.pool2.impl.BaseGenericObjectPool.setEvictionPolicyClassName(BaseGenericObjectPool.java:618)
    at org.apache.commons.pool2.impl.GenericObjectPool.setConfig(GenericObjectPool.java:318)
    at org.apache.commons.pool2.impl.GenericObjectPool.<init>(GenericObjectPool.java:115)
    at org.apache.commons.pool2.impl.GenericObjectPool.<init>(GenericObjectPool.java:88)

 

Version 2.5.0 throws the same exception. Version 2.4.2 or older's setEvictionPolicyClassName method fail silently for the same reason. This line in BaseGenericObjectPool evaluates to false for all versions:

        if (policy instanceof EvictionPolicy<?>) {