Uploaded image for project: 'Commons Pool'
  1. Commons Pool
  2. POOL-246

[PATCH] Follow same pattern in ErodingKeyedObjectPool#toString as in other pool objects

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1
    • Labels:

      Description

      Hello!

      In ErodingObjectPool, the toString method outputs: ErodingObjectPool

      {factor=$FACTOR, pool=$POOL}

      And in ErodingPerKeyKeyedObjectPool it outputs:
      ErodingPerKeyKeyedObjectPool

      {factor=, keyedPool=$POOL}

      However, in ErodingKeyedObjectPool, the factor has a different prefix: ErodingKeyedObjectPool

      {erodingFactor=$FACTOR, keyedPool=$POOL}

      This proposed patch follows the same pattern as in the aforementioned pools and changes ErodingKeyedObjectPool#toString.

      Please, note that POOL-244 contains tests that may fail due to this change, so during the merge it may be good to take a look at TestPoolUtils#testErodingPoolKeyedObjectPoolDefaultFactor to avoid build errors.

        Attachments

        1. POOL-246.patch
          0.6 kB
          Bruno P. Kinoshita

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              kinow Bruno P. Kinoshita
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: