[POOL-209] SharedPoolDataSource does not handle null keys correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Cannot Reproduce

Environment

Windows, java version "1.6.0_06", Torque 3.3 (DBCP 1.4, jTDS 1.2.5)

• Assignee: Unassigned
• Reporter: Gabor Horvath
• Created: 15/Apr/10 07:49
• Updated: 31/Dec/14 16:26
• Resolved: 10/Jan/13 15:44

Description

GenericKeyedObjectPool.borrowObject does not invalidate object if validateObject fails (line ~1200). I guess invalidation would be needed for objects which are not newly created (newlyCreated flag in the code).

Scenario:
1.) DB connection put into pool
2.) Attempt to reuse connection (borrowObject)
3.) Test on borrow (executing simple SQL query) fails: DB connection closed on jTDS level but connection remains in the pool
4.) Subsequent attempts to reuse the connection causes "java.sql.SQLException: Invalid state, the Connection object is closed"